✨ [Frontend] Check if I can write_functions
#7888
Merged
+64
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
write_functions
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the “Create Functions” section is only shown when the user’s group has the write_functions permission by:
- Adding a new
functionPermissionsendpoint and loading both general and function-specific permissions at startup - Refactoring
Permissionsto store and expose group-level and function-level permissions viacheckMyGroupCanDoandcheckFunctionPermissions - Updating UI components (
NodeOptions,ResourceDetails) to use the new permission checks and automatically rebuild layouts
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/widget/NodeOptions.js | Renamed buildLayout to private __buildLayout and applied it on node property; switched permission check to checkMyGroupCanDo |
| services/static-webserver/client/source/class/osparc/desktop/WorkbenchView.js | Removed manual buildLayout call now handled by the property apply |
| services/static-webserver/client/source/class/osparc/desktop/MainPage.js | Preload both general and function permissions before rendering |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Added functionPermissions resource definition |
| services/static-webserver/client/source/class/osparc/data/Permissions.js | Introduced __permissions and __functionPermissions, methods to fetch and check them |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Changed plugin-disabled check to use checkFunctionPermissions |
Comments suppressed due to low confidence (3)
services/static-webserver/client/source/class/osparc/data/Permissions.js:300
- [nitpick] Consider adding a JSDoc comment to explain the purpose of
fetchFunctionPermissionsand its relationship with__functionPermissions.
fetchFunctionPermissions: function() {
services/static-webserver/client/source/class/osparc/desktop/MainPage.js:73
- New startup permission-fetching logic should be covered by tests to ensure both general and function permissions are loaded before the UI displays.
preloadPromises.push(osparc.data.Permissions.getInstance().fetchPermissions());
services/static-webserver/client/source/class/osparc/data/Permissions.js:317
- The variable
functionPermissionsis undefined here; it should referencethis.__functionPermissions[action].
return functionPermissions[action];
|
odeimaiz
requested review from
wvangeit,
pcrespov,
JavierGOrdonnez,
giancarloromeo,
GitHK,
sanderegg,
matusdrobuliak66 and
bisgaard-itis
|
@mergify queue |
🟠 Waiting for conditions to match
|
odeimaiz
changed the title
write_functionswrite_functions
sanderegg
approved these changes
Jun 16, 2025
JavierGOrdonnez
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In order to show the
Create Functionssection, the user needs to belong to a group that is allowed towrite_functions.Related issue/s
/me/function-permissionsEndpoint in Functions Domain #7901How to test
Dev-ops